[FLINK-1165] No createCollectionsEnvironment in Java API#320
Closed
ajaybhat wants to merge 2 commits into
Closed
Conversation
added 2 commits
January 19, 2015 16:19
This commit adds a new method to ExecutionEnvironment to create a CollectionEnvironment, and applies the method to cases where a CollectionEnvironment() may be needed
…method to createCollectionEnvironment()
Contributor
Author
|
Fixed the typos. |
Contributor
|
Thanks :) Personally, I'm fine with both variants, but if the Scala variant is already called Collections environment, I would go for the same name and leave the Scala API as it is. |
Contributor
|
I vote to call it Otherwise this is good to merge. Thanks, Ajay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new method to ExecutionEnvironment to create a
CollectionEnvironment, and applies the method to cases where a
CollectionEnvironment() may be needed